search

edina / nbexchange

External exchange for nbgrader
Other
6 stars 2 forks source link

Wrap all file handling with a `with` statement #50

Closed agxs closed 3 years ago

agxs commented 3 years ago

This makes sure files are all correctly closed, including some files which weren't being close at all because they weren't actually calling close().

codecov[bot] commented 3 years ago

Codecov Report

Merging #50 (99b41fb) into master (df98480) will decrease coverage by 0.05%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #50      +/-   ##
==========================================
- Coverage   76.69%   76.63%   -0.06%     
==========================================
  Files          43       43              
  Lines        2094     2089       -5     
==========================================
- Hits         1606     1601       -5     
  Misses        488      488
Impacted Files Coverage Δ
nbexchange/handlers/assignment.py 78.17% <100.00%> (-0.22%) :arrow_down:
nbexchange/handlers/collection.py 89.18% <100.00%> (-0.10%) :arrow_down:
nbexchange/handlers/feedback.py 86.95% <100.00%> (-0.12%) :arrow_down:
nbexchange/handlers/submission.py 78.78% <100.00%> (-0.32%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update df98480...99b41fb. Read the comment docs.