Closed perllaghu closed 3 years ago
So instead of logging one action for feedback now there is one action per file, is that correct? Does the plugin need updating in any way to deal with this change?
So instead of logging one action for feedback now there is one action per file, is that correct? Does the plugin need updating in any way to deal with this change?
Correct.... and in line with what the release-feedback
does
The plugin needs no alternation - the database action
logging is purely exchange-side.
I mean are there APIs that now might be returning more data to the plugin, much like the /collections API where actions might need filtered/coalesced to avoid returning too many rows?
Merging #53 (5b59877) into master (47c0e09) will not change coverage. The diff coverage is
100.00%
.
@@ Coverage Diff @@
## master #53 +/- ##
=======================================
Coverage 76.57% 76.57%
=======================================
Files 43 43
Lines 2083 2083
=======================================
Hits 1595 1595
Misses 488 488
Impacted Files | Coverage Δ | |
---|---|---|
nbexchange/handlers/feedback.py | 86.95% <100.00%> (ø) |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 47c0e09...5b59877. Read the comment docs.
The "fetch_feedback" handler in the exchange was
This fixes both of those.
(Yes, it's perfectly possible for the call to run, and successfully report zero items)