edina / nbexchange

External exchange for nbgrader
Other
6 stars 2 forks source link

Change the way fetch-feedback is logged #53

Closed perllaghu closed 3 years ago

perllaghu commented 3 years ago

The "fetch_feedback" handler in the exchange was

  1. reporting every time it ran, rather than when it actually had files
  2. didn't actually say what was being fetched.

This fixes both of those.

(Yes, it's perfectly possible for the call to run, and successfully report zero items)

agxs commented 3 years ago

So instead of logging one action for feedback now there is one action per file, is that correct? Does the plugin need updating in any way to deal with this change?

perllaghu commented 3 years ago

So instead of logging one action for feedback now there is one action per file, is that correct? Does the plugin need updating in any way to deal with this change?

Correct.... and in line with what the release-feedback does

The plugin needs no alternation - the database action logging is purely exchange-side.

agxs commented 3 years ago

I mean are there APIs that now might be returning more data to the plugin, much like the /collections API where actions might need filtered/coalesced to avoid returning too many rows?

codecov[bot] commented 3 years ago

Codecov Report

Merging #53 (5b59877) into master (47c0e09) will not change coverage. The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #53   +/-   ##
=======================================
  Coverage   76.57%   76.57%           
=======================================
  Files          43       43           
  Lines        2083     2083           
=======================================
  Hits         1595     1595           
  Misses        488      488           
Impacted Files Coverage Δ
nbexchange/handlers/feedback.py 86.95% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 47c0e09...5b59877. Read the comment docs.