search

edina / nbexchange

External exchange for nbgrader
Other
6 stars 2 forks source link

Bug: collections handler fails because action.location is NULL #84

Closed BertR closed 3 years ago

BertR commented 3 years ago

I've got a request:

Could you write a test for nbexchange that 

Calls the collections handler 
- for a valid instructor
- for a valid course
- With a valid submission for that course
- With a feedback_fetched action for that assignment with an empty "location" field

This should break the collections handler (as it did for one of our users in UniDesk call I210419-1741). Once the test is written (and red), we can think about ways to fix this.

perllaghu commented 3 years ago

Can I confirm you're talking collection of a student submission rather than collection of feedback by a student (where the location is null)

The collection of a student submission should have no interest in whether feedback exists or not.

We should also consider verifying that location is always defined, for every action... and how we fail when that location has not been defined

BertR commented 3 years ago

Can I confirm you're talking collection of a student submission rather than collection of feedback by a student (where the location is null)

The collection of a student submission should have no interest in whether feedback exists or not.

We should also consider verifying that location is always defined, for every action... and how we fail when that location has not been defined

GET /services/nbexchange/collections is the handler this is about.

perllaghu commented 3 years ago

I'll have a look - that handler should not care about feedback at all.

perllaghu commented 3 years ago

I didn't think it would make a difference

Branch 84_blank_path_breaks_collections has three additional tests