BertR commented 3 years ago

Because of how pip and setuptools deal with git dependencies, we sometimes ran into issues (pip install . vs python setup.py install would yield different results.)

By moving to pyproject.toml, we can have a single reference to the nbgrader commit we want to install. pip install . will reference the dependencies in pyproject.toml python setup.py install will no longer work.

codecov[bot] commented 3 years ago

Codecov Report

Merging #88 (3b67957) into master (6f6a0bf) will increase coverage by 6.31%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master      #88      +/-   ##
==========================================
+ Coverage   79.55%   85.87%   +6.31%     
==========================================
  Files          44       71      +27     
  Lines        2211     5719    +3508     
==========================================
+ Hits         1759     4911    +3152     
- Misses        452      808     +356

Impacted Files	Coverage Δ
nbexchange/__init__.py	`100.00% <100.00%> (ø)`
nbexchange/handlers/pages.py	`100.00% <100.00%> (ø)`
nbexchange/tests/conftest.py	`100.00% <0.00%> (ø)`
nbexchange/tests/test_handlers_collection.py	`80.66% <0.00%> (ø)`
nbexchange/tests/test_handlers_base.py	`100.00% <0.00%> (ø)`
nbexchange/tests/test_plugin_collect.py	`95.12% <0.00%> (ø)`
nbexchange/tests/test_plugin_submit.py	`66.51% <0.00%> (ø)`
nbexchange/tests/test_smoketest.py	`100.00% <0.00%> (ø)`
nbexchange/tests/test_handlers_feedback.py	`94.76% <0.00%> (ø)`
nbexchange/tests/utils.py	`77.77% <0.00%> (ø)`
... and 20 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 6f6a0bf...3b67957. Read the comment docs.

perllaghu commented 3 years ago

There's a merge conflict still sitting in pages.py

edina / nbexchange

Move from setup.py to pyproject.toml #88

Codecov Report