Closed perllaghu closed 3 years ago
Currently feedback handler queries models thus:
feedback
assignment = ( session.query(nbexchange.models.assignments.Assignment) .filter_by(assignment_code=assignment_id, course_id=course.id) .first() )
whilst the rest of the handlers do the same thing thus:
assignment = nbexchange.models.assignments.Assignment.find_by_code( db=session, code=assignment_code, course_id=course.id, action=nbexchange.models.actions.AssignmentActions.released.value, )
I don't mind which way we go - but I'd like to see consistency.
Closed by PR 83 (https://github.com/edina/nbexchange/pull/83/files)
Currently
feedback
handler queries models thus:whilst the rest of the handlers do the same thing thus:
I don't mind which way we go - but I'd like to see consistency.