edisionnano / Screenshare-with-audio-on-Discord-with-Linux

A repo trying to gather all info regarding proper screensharing on Discord with Desktop Audio for linux users
680 stars 11 forks source link

Fix sink creation bug #6

Closed honkfestival closed 2 years ago

honkfestival commented 2 years ago

This PR fixes an issue I encountered where the virtmic wasn't receiving audio from the sink I'd created earlier, so Discord wasn't sharing the audio I'd intended. I'm using Regolith based on Ubuntu 21.10 with an upstream PipeWire (0.3.42).

After debugging with @edisionnano (thanks again! :pray:), we discovered that the $SINK_NAME was inside single quotes '' and therefore not interpolated. Moving the $SINK_NAME just outside fixes the issue.

This PR also includes some minor edits for readability; the main fix is in 00c88e84f6ab8c39bf3c67a6201a4c7013b98e19 if you don't want the rest. :)

edisionnano commented 2 years ago

Thanks