Closed htot closed 6 years ago
Personally I don't think it's a good idea to support ACPI stuff in main branch. ACPI is quite experimental and may break things. I would definitely not recommend to use it right now for anything, except development and testing.
I think it might make sense to put put master branch -> legacy, pyro64->master and keep pyro64 and pyro64-acpi as experimental
Up to you, my concern is to not mix ACPI vs. non-ACPI stuff for now.
@alext-mkrs can we create a variable for the conf file that enables the build of acpi enabled kernel, u-boot and installs aml, while by default no acpi?
Yes, I think there's a way to do that, but I'll need to look up specific variables/classes to use, I'm not near tye computer right now - will look into that tomorrow or over the wekend.
I am currently trying this:
SRCREV ??= "${@bb.utils.contains('DISTRO_FEATURES', 'acpi', '47fcae6e94a42b34d4a0d491b88dda3607261070', '35488d97cc867fdf020aed23eb8d62ab3a273c74', d)}"
LINUX_VERSION_EXTENSION ??= "${@bb.utils.contains('DISTRO_FEATURES', 'acpi', '-edison-acpi-${LINUX_KERNEL_TYPE}', '-edison-no-acpi-${LINUX_KERNEL_TYPE}', d)}"
with 'acpi' added to DISTRO_FEATURES in poky-edison.conf
I hope to have tackled the acpi/no-acpi selection and for no-acpi retrieving u-boot from upstream.
...github didn't fully refresh the page before my last comment, so I didn't see you went the direct assignment way with LINUX_VERSION_EXTENSION
- that looks ok to me. I'll test this PR today and report back.
Non-acpi builds fine (kernel, u-boot and image), checking the acpi one now.
ACPI-enabled build ok as well, haven't yet tried to run those.
This PR is getting quite messy with comments. Shall I close it and reopen a new?
There's a better way - just squash all your commits created by now and force-push to the same branch. GH will update the PR and mark all the inline comments as obsolete + hide them by default.
I'll rewrite the history
Rearranged and squashed some commits. No functional changes intended.
Thanks for reviewing!
My pleasure. Sorry I wasn't able to check out the post-squashing version yet, but as that's just housekeeping, it should be ok.
Problems:
Todo: