Closed htot closed 5 years ago
Generally looks ok, but the last commit needs checking, such merge commits pollute the history, plus it seems to duplicate some other changes (I took only a cursory glance at that one though - my internet access is intermittent at the moment)
I'll remove that last one then. I was experimenting to see if it makes sense to group commits with a merge commit so it is more clear they belong together. I can wait a bit for you to build and test?
Removed the merge commit and upgraded u-boot to the freshly released 2018.09
Thanks! Those merge commits clump stuff together, so they're really just a history pollution, haven't seen anyone using them - mostly the opposite, everyone prohibits them.
My internet and build machine access is going to be on-and-off for about a week or so, not sure if you'd want to wait that long, as realistically I'll be able to test only some time next week and most probably closer to the end of it. I think you can merge if it works for you and we can sort out problems later if needed.
Thanks! Those merge commits clump stuff together, so they're really just a history pollution, haven't seen anyone using them - mostly the opposite, everyone prohibits them.
I saw the linux kernel doing that and wondered if there was an advantage to that, like making sure that each commit results in a working build. But I agree, on GH it messes up the review process.
My internet and build machine access is going to be on-and-off for about a week or so, not sure if you'd want to wait that long, as realistically I'll be able to test only some time next week and most probably closer to the end of it. I think you can merge if it works for you and we can sort out problems later if needed.
Alright. I suspect I messed up .gitignore, don't know in which commit yet. So I will fix that first and then pull.
And let the sorting out begin :-)
This brings some interesting advances: