search

edison-fw / meta-intel-edison

Here is the meta-intel-edison that builds, tries to stay up to date. Master is based on Yocto Poky Gatesgarth LTS 5.10.yy vanilla kernels. It builds a 32bit kernel (Gatesgarth branch 64bit) with ACPI enabled and corresponding rootfs. Telegram group: https://t.me/IntelEdison Web-site:
https://edison-fw.github.io/meta-intel-edison/
MIT License
60 stars 37 forks source link

Added support to the meta-intel-edison-bsp and meta-intel-edison-distro layers for the master(warrior) branch #64

Closed nishantpoorswani closed 4 years ago

nishantpoorswani commented 4 years ago

Signed-off-by: nishantpoorswani nishantpoorswani@gmail.com

The master branch in Yocto has now moved from thud to warrior and hence, the image for the edison board wasn't compiling. I've added the warrior branch to the LAYERSERIES_COMPAT variable in both the meta-intel-edison and meta-intel-edison-distro layers. This now compiles successfully with the master Yocto branch.

htot commented 4 years ago

Thanks. I am traveling now, but check this when I return.

alext-mkrs commented 4 years ago

While this is simple and looks good to me, based on the past experience, this won't be enough to migrate the layer to warrior. This setting is just to stop bitbake from complaining about layer incompatibility with the specific Yocto release, but it doesn't magically make it compatible.

nishantpoorswani commented 4 years ago

Hi @alext-mkrs , I built an image for the Intel edison on the master branch using the poky distro and it works fine. For meta-intel-edison-distro layer, more changes will be required depending on the package bumps for warrior.

nishantpoorswani commented 4 years ago

A quick update, I'm done with the other changes as well. Now edison-minimal builds with the poky-edison distro. I'll be sending the patches soon. Should I make a separate Pull request for those patches?

Also the edison-image compiles with the master branch with the additional patches.

htot commented 4 years ago

There is an earlier PR from @PieterGIt here: https://github.com/htot/meta-intel-edison/pull/2/commits. It needs re-basing, but the first part is concerned about upgrading to warrior. The 2nd part is to build debian, which as I understand is a WIP. Maybe you can re-use in part?

nishantpoorswani commented 4 years ago

Hi @htot I've made the changes for the master branch. Sorry for the delay. I compiled the edison-image and it works perfectly. Could you please review it?

htot commented 4 years ago

@nishantpoorswani thanks I certainly will. 2 things are delaying me: 1 temperature in my attic where PC and Edison live is too high to play 2 extremely overloaded at work (expect to resolve after Friday)

nishantpoorswani commented 4 years ago

@htot whenever possible

nishantpoorswani commented 4 years ago

Hi @htot Any updates on this?

htot commented 4 years ago

I have been working on meta-acpi patches first and hope to get to this this weekend. Thanks for your patience.

htot commented 4 years ago

@nishantpoorswani applying your patches to master will upgrade that to warrior, so I want to release thud first. I have been working to get everything in place for that to happen this weekend, just need to test it before pushing to htot/meta-intel-edison. Then I'll send a PR to edison-fw for that. And create a warrior branch and pull your patches to htot/meta-intel-edison.

nishantpoorswani commented 4 years ago

@htot Sounds good to me

htot commented 4 years ago

I pushed a new warrior branch https://github.com/htot/meta-intel-edison/tree/warrior with above patches and some more. @nishantpoorswani would you care to test this? It builds a 64bit kernel. I works for me, but I reordered patches after building and changed "u-boot: Fix path to merge_config.sh" to ed139db5 without testing.

Also I'd still like to hear from @alext-mkrs if we lose a lot by disabling upm nodejs bindings for now?

nishantpoorswani commented 4 years ago

@htot The patch for u-boot: Fix path to merge_config.sh doesn't apply because there's a slight mistake in the naming in the setup.sh(Line 348). The name should be 0001-u-boot-Fix-path-to-merge_config.sh.patch instead of 0001-u-boot-Fix-path-to-merge_config.sh

htot commented 4 years ago

@nishantpoorswani Sorry, that's a dumb mistake. Fixing now.

nishantpoorswani commented 4 years ago

@htot I've tested the https://github.com/htot/meta-intel-edison/tree/warrior branch. It builds perfectly.

htot commented 4 years ago

@nishantpoorswani thanks. I ran the image from usb too without problems. Now locally I have with u-boot 2019-7 and kernel 5.3. I find a small issue there with dwc3-pci that I hope to resolve. I hope in the mean time we can release thud and then pull warrior into master.

htot commented 4 years ago

@nishantpoorswani is reboot working for you? I updated to linux 5.3 and it is not, but I forgot to check proper when still on 5.2. I see your patch is applied on b/units/systemd-reboot.service.in, but on the image is only an unpatched /lib/systemd/systemd-reboot.service.

On 5.3 reboot hangs until watchdog reset. Manually copying in your patch to /lib/systemd/systemd-reboot.service reboot doesn't do anything at all.

Any ideas?

alext-mkrs commented 4 years ago

@htot, as far as UPM bindings are concerned - well, if it doesn't work, it doesn't work :) I don't see anything reported in the UPM repo, so probably upstream doesn't know yet. Probably worth reporting there.

htot commented 4 years ago

@alext-mkrs Upstream master switched to 2.0 :-)

htot commented 4 years ago

I pushed these patches with fixes and additional patches to https://github.com/htot/meta-intel-edison (master for 32 bits, warrior for 64 bits). So I will close this now. htot/meta-intel-edison will eventually be pulled into edison-fw/meta-intel-edison after review by @alext-mkrs.

Thanks @nishantpoorswani for your work.

nishantpoorswani commented 4 years ago

Hi @htot Sorry for the late reply. I've been really busy lately. I hadn't tested the reboot but I'm glad that you've managed to get it running. I'm really glad that I could help :)