edisonywh / backoffice

Admin tool built with the PETAL stack
MIT License
217 stars 15 forks source link

Remove dependency on Scrivener.Ecto? #8

Closed edisonywh closed 3 years ago

edisonywh commented 3 years ago

Right now Backoffice expects Resolvers to return a page struct, which is basically whatever Scrivener.Ecto returns. However this dependency isn't exactly clear nor is it required/documented. We should either document it, or even remove the dependency on Scrivener.Ecto and just handle it within Backoffice.

Reference: https://github.com/drewolson/scrivener_ecto/blob/master/lib/scrivener/paginater/ecto/query.ex

edisonywh commented 3 years ago

Fixed in #20