Closed th0ma7 closed 3 years ago
@edit4ever I tried adding a few features and make the code compatible to direct python3 call from shell. Let me know what you think of it and whether some of the commits are applicable.
@edit4ever I've added configuration xml files as demonstration on how language could be auto-managed.
lang=en
when not found or proper language when found.Again, food for thoughts.
I'll take a look at these ideas as I get some time. However - it looks like you've been referencing the Master branch - but there is a Python 3 branch that would be more appropriate for you to be working off of. Master was left in the python 2 old code and I hadn't gotten around to merging the Python 3 branch into Master.
So you might want to relook at your pull requests and rework them onto the Python 3 branch - as the current Master branch is not up to date.
@edit4ever I've created a new PR https://github.com/edit4ever/script.module.zap2epg/pull/37 to replace most of this one (besides the python2-3 convert).
I'll come back with another PR relating the language management proposal I have in mind.
There really is a need to allow setting lang=fr
for french channels so accentuated characters gets interpreted properly in both kodi and TVH as otherwise éèê
... ends-up being î
or é
... In the meantime I'll open-up an issue to follow that.
First comment: it runs really well and it's really fast! Nice work!
Other opportunities for improvement:
<subtitles type="teletext" />
can be added<length units="minutes">60</length>
tagpremiere
andlast-chance
flagsLanguage...I believe it can be better managed. Issue is: if set in frech I believe it sets it for everything, which is not true at all. I think any non-english channels should have a representative flag. Then, having a category dictionary, the categories could be added for those channels in both languages (default
lang=en
+ specific to that channel)Food for thoughts:
lang=
flag based on the configuration, else set it to englishlang=
tag.