search

editeodoro / Bbarolo

Bbarolo is a 3D fitting tool to derive the kinematics of galaxies from emission-line observations.
http://editeodoro.github.io/Bbarolo/
GNU General Public License v2.0
30 stars 8 forks source link

Cannot achieve Convergence with git-version #15

Closed Mixpap closed 4 years ago

Mixpap commented 4 years ago

After compiling the latest git version of Bbarolo the code cannot achieve convergence where with the same configuration file/data and the stable version it can.

Tried with the DELTAVROT option on and off. Both examples tried to fit VROT VRAD INC VDISP PA

Michalis

editeodoro commented 4 years ago

Hi Michalis, thanks for reporting this, I had messed up with some array indexes. It should be fixed now. Let me know if you see any additional issue.

Note: I had to add some degree of randomness in the re-initialization of the simplex when the algorithm samples regions outside the boundaries. This causes the algorithm to converge to slightly different minima at each run when the boundaries are not large enough to sample properly the parameter space. The minimum however looks always consistent within the errors, thus it should not be a big deal.

Enrico

Mixpap commented 4 years ago

Hi Enrico, it seems it is working well so far. Maybe you can close the issue. Thank you. Michalis

editeodoro commented 4 years ago

Thanks