search

editeodoro / Bbarolo

Bbarolo is a 3D fitting tool to derive the kinematics of galaxies from emission-line observations.
http://editeodoro.github.io/Bbarolo/
GNU General Public License v2.0
30 stars 8 forks source link

Add ability to write bad rings. #19

Closed kyleaoman closed 3 years ago

kyleaoman commented 3 years ago

I've added a new feature that I've wanted for a while. It adds a new parameter for 3DFIT called BADOUT (default: FALSE). If this parameter is set, rings which fail to converge, etc., will still be written to the output files (with bad values). A new column FITOK will also be added to the output, which will be 1 for rings which succeeded and 0 for rings which failed. This makes automatically checking for failed rings easier (previously, either needed to check the ring radii against a list of expected rings, or attempt to parse the stdout messages).

Note that I've only implemented the basics: recognise the new parameter when parsing the parameter file, and decide whether to write extra output to file. I haven't updated documentation, or the pyBB interface, which I guess should be done before merging...

editeodoro commented 3 years ago

Hi Kyle, thanks for this addition, it can be quite handy indeed. I will check the pull request + documentation + pyBB interface before merging it.

Enrico