search

editeodoro / Bbarolo

Bbarolo is a 3D fitting tool to derive the kinematics of galaxies from emission-line observations.
http://editeodoro.github.io/Bbarolo/
GNU General Public License v2.0
30 stars 8 forks source link

I found a bug, and I fixed it. Can I make a PR for you? #24

Closed This-Researcher closed 2 years ago

This-Researcher commented 2 years ago

Hi @editeodoro and @kyleaoman!

This program is fantastic!

I found a tiny problem though. The output stage fails if the path has spaces in it. For example: /home/me/this path has spaces/output/galaxy_files

Here is a screenshot of the error: Something went wrong! Check plotting scripts in the output folder image

I fixed it by adding escaped quotation marks around the paths. Now, it works with no errors: image

I made a new github branch called "_bugfix/spaces_in_path_". May I submit it to your repository as a Pull Request?

editeodoro commented 2 years ago

Hi @This-Researcher, thanks for finding and fixing this! Sure, feel free to submit a PR.

Cheers, Enrico