MINOR BUG: 3D Fit parallelization does not seem to work linux

editeodoro / Bbarolo

Bbarolo is a 3D fitting tool to derive the kinematics of galaxies from emission-line observations.

http://editeodoro.github.io/Bbarolo/

GNU General Public License v2.0

30 stars 8 forks source link

MINOR BUG: 3D Fit parallelization does not seem to work linux #8

Closed Punzo closed 6 years ago

Punzo commented 6 years ago

I don't see the 3DFit code using the 4 threads as specified in the parameters files (ubuntu 17.10).

Screenshot running meanwhile running 3DFIt (using the fits and par files from example) screenshot from 2018-03-28 10-01-34

configure output out.txt

editeodoro commented 6 years ago

Can you also send me a screenshot of the BBarolo's run?

Punzo commented 6 years ago

Hi @editeodoro, I rechecked this with the last git tag. I does work now (not sure what was the issue before) and the speedup it is nice.

The print of the rings of course it will not be anymore in crescent index order: out.txt

You may think to run the openMP fork in static and print the rings only when a group of N threads has finished the computation (of course this will reduce the performance and probably it is not worth).

I'll close this issue.