search

editor-js / embed

Embed Tool for Editor.js
MIT License
147 stars 107 forks source link

Twitch Embedded Player has updated #31

Open natsumework opened 4 years ago

natsumework commented 4 years ago

Twitch dose not work, cause Twitch Embedded Player has updated.

Twitch Embedded Player Updates in 2020

Before

<iframe src="https://player.twitch.tv/?channel=twitchpresents" />

After

<iframe src="https://player.twitch.tv/?channel=twitchpresents&parent=streamernews.example.com&parent=embeds.example.com" />

Newnab commented 3 years ago

Seconding this report - but note that you only need 1 parent query variable if your site only has 1 URL. Multiples should work if you have multiple URLs that can view the same content.

I guess the simplest thing to do would be to fetch the current domain and throw that in, but if you use editor.js in a scenario where your editor has a different domain to your front end then that solution wouldn't work. It might need to bring up a modal and ask you to specify your domain whitelist?