Closed tanepiper closed 5 years ago
Hi @talyguryn @gohabereg sorry to ping you, but this PR has been open for two weeks.
Would it be possible to merge this change? In my code to fix this, I extend the class but it's currently breaking my tests and this quick fix would resolve that.
Thanks
Hi @tanepiper ,
Sorry for delay! Fix is ok, could you please patch the version, build the package using yarn build
and include build files to PR.
Thanks!
@gohabereg No problem, done - but it looks like there is a conflict to resolve
There are conflicting files, I guess you need to pull the master and rebuild the package
The existing code does not work with Angular, and possibly other Webpack bundlers where they optimize code.
The issue is that this code gets generated:
When running this,
t
's existing properties are readonly so it cannot overwrite them, this patch fixes it.