search

editor-js / list

Advanced List tool for the Editor.js.
MIT License
48 stars 47 forks source link

The List plugin stopped working with the latest 2.0 version #110

Closed eliezerben closed 3 days ago

eliezerben commented 1 week ago

With the 2.0 version of the list plugin, we are seeing this error: Uncaught ReferenceError: List is not defined

When I use v1.10.0, it works fine.

Code which throws error:

<script src="https://cdn.jsdelivr.net/npm/@editorjs/list@latest"></script>
...
...

                list: {
                    class: List,       // This line
                    inlineToolbar: true,
                    shortcut: 'CMD+SHIFT+L'
                },
---
magarrent commented 6 days ago

Same here!

e11sy commented 6 days ago

since List 2.0 we desided to rename class to EditorjsList, so 

<script src="https://cdn.jsdelivr.net/npm/@editorjs/list@latest"></script>
...

                list: {
                    class: EditorjsList,
                    inlineToolbar: true,
                    shortcut: 'CMD+SHIFT+L'
                },

would work

magarrent commented 6 days ago

since List 2.0 we desided to rename class to EditorjsList, so

<script src="https://cdn.jsdelivr.net/npm/@editorjs/list@latest"></script>
...

                list: {
                    class: EditorjsList,
                    inlineToolbar: true,
                    shortcut: 'CMD+SHIFT+L'
                },

would work

Is this documented somewhere?? Didn’t see anything

thecliffparis commented 3 days ago 
<script src="https://cdn.jsdelivr.net/npm/@editorjs/list@latest"></script>
...

                list: {
                    class: EditorjsList,
                    inlineToolbar: true,
                    shortcut: 'CMD+SHIFT+L'
                },

With the update, adding a List item is working fine now. But if we try to convert a text into a list, the list option is not available.

What shall we do to display the option List in the conversion menu ?

thecliffparis commented 3 days ago 
<script src="https://cdn.jsdelivr.net/npm/@editorjs/list@latest"></script>
...

                list: {
                    class: EditorjsList,
                    inlineToolbar: true,
                    shortcut: 'CMD+SHIFT+L'
                },

With the update, adding a List item is working fine now. But if we try to convert a text into a list, the list option is not available.

What shall we do to display the option List in the conversion menu ?

Working fine... Just needed to remove legacy Checklist. EditorjsList is the only needed for all lists.

eliezerben commented 3 days ago

Would be great if the docs were updated. https://github.com/editor-js/list#usage