search

editor-js / list

Advanced List tool for the Editor.js.
MIT License
48 stars 47 forks source link

Migrate to typescript #72 #73

Closed yuan-93 closed 3 months ago

yuan-93 commented 5 months ago

Resolve #72 Migrate to Typescript

Changes

  1. Add Typescript
  2. Add dev dependencies @editorjs/editorjs to use its type
  3. Add .d.ts for @codexteam/icons
  4. Convert js files to ts files and update relevant interfaces and types
  5. Add type-guard to safely infer js Node to HtmlElement
  6. Add tsconfig.json
  7. Add vite-plugin-dts to generate types during build
  8. Add dev dependencies @typescript-eslint/eslint-plugin, @typescript-eslint/parser to support eslint typescript
  9. Update "yarn lint" to target .ts files
  10. Copy editorconfig from @editorjs/editorjs to have same code formatting
  11. Add "yarn build" on pull request at github workflow to build dist folder
  12. Increment patch version from v1.4.2 to v1.4.3
yuan-93 commented 4 months ago

Thanks for reviewing @neSpecc Here are the changes made according to your review

Changes

  1. remove build step in eslint github workflow
  2. use and update list data style
  3. make default style optional
  4. make dom helper allow to add any attributes
  5. update to use readied type from editorjs
  6. update doc
neSpecc commented 3 months ago

Hey, @yuan-93, would you help us finishing this pr? We're planning a big update of this tool, so this step is important.

yuan-93 commented 3 months ago

yea @neSpecc , I think i will helpout in this weekend

neSpecc commented 3 months ago

Thanks, @yuan-93, very professional work. If you are interested in continuing, let me know.