search

editor-js / table

Table constructor for Editor.js
MIT License
126 stars 137 forks source link

feature: RTL Support #152

Open hamidKMB opened 3 months ago

hamidKMB commented 3 months ago

right now the RTL direction looks like a disaster. it'll be very great if your team implements this feature

hamidKMB commented 3 months ago

I'd like to help your team develop this feature, just let me know how I can do this

neSpecc commented 3 months ago

Thanks, @hamidKMB . First, let's update your issue with details. Create a list of bad-looking places

hamidKMB commented 3 months ago

hi @neSpecc . I hope you doing well.

I created an editorjs playground in codesandbox you can check it if you want to test the below items playground codesandbox https://codesandbox.io/s/editor-js-forked-r6gtt6?file=/src/editor.js:

better to open it in new window

before everything I have to mention that plus the bad-looking parts there are some functionality problems that I've mentioned below

Bad-looking Problems 1- the add-column button integrated with the table editorjs-add-column-bad-looking

2- the column toolbox selects the wrong column column-toolbox-bad-looking

3- both LTR and RTL direction shows the sider-quick-compose-btn element like below sider-quick-compose-btn-bad-looking

Functionality Problems:

  1. the add-column integrated with the table not working at all. even hovering does not apply to it
  2. in the column toolbox doesn't matter user clicks on add a column to the left or right, it always adds a column to the left

===============================================================================

the rows toolbox and button integrated with the table work fine and haven't any problem

neSpecc commented 2 months ago

@hamidKMB Seems clear now. You can try to resolve these problems.

KoushyarHB commented 2 days ago

Does anyone have any success in resolving these issues? I'm dealing with the same problem