editorconfig-checker / editorconfig-checker.javascript

A tool to verify that your files are in harmony with your .editorconfig
https://editorconfig-checker.github.io/
MIT License
70 stars 10 forks source link

fix: bring back support for http proxies #395

Closed nejch closed 1 year ago

nejch commented 1 year ago

Closes #394.

@mstruebing I think this should do the trick but let me know what you think (you can test locally https_proxy=fake dist/index.js docs fails, https_proxy=fake no_proxy=* dist/index.js docs works).

Would you be able to push a new release to npm after merge if you're happy with this fix? :bow:

eslint complains about the unused tar import but I didn't want to touch the unrelated code :)

/cc @antoineauger @bufferoverflow

nejch commented 1 year ago

@mstruebing would you be interested in this fix? It basically brings back old behavior. Let me know if anything's missing :bow: thanks!

nejch commented 1 year ago

If this needs some tests or more explanation to get merged, happy to try and add or change the approach here if needed. :)

bufferoverflow commented 1 year ago

@chalkygames123 @mondeja Could you maybe have a look at this PR? Thanks!

fgreinacher commented 1 year ago

@mstruebing Sorry for the ping, do you see a chance to get this in? It's really a bit cumbersome and the fix looks totally reasonable.

mstruebing commented 1 year ago

I've merged it but the CI pipeline is failing on main, tried to update dependencies but still getting errors. PRs to fix that are appreciated

mstruebing commented 1 year ago

I've published 5.1.0 - let me know if you have any problems.

nejch commented 1 year ago

Thanks a lot @mstruebing! I think the failures were unrelated but saw @fgreinacher also took care of that :bow:

I've already tested the new version and seems to work well so far :+1: thanks for getting this published so quick after the merges.

github-actions[bot] commented 4 months ago

:tada: This PR is included in version 1.5.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: