editorconfig-checker / editorconfig-checker.javascript

A tool to verify that your files are in harmony with your .editorconfig
https://editorconfig-checker.github.io/
MIT License
70 stars 10 forks source link

fix: allow Node.js versions >= 18 #400

Closed theoludwig closed 1 year ago

theoludwig commented 1 year ago

Hello!

Since https://github.com/editorconfig-checker/editorconfig-checker.javascript/commit/1bc42852f461a33df6aee12ac920afbf841ded03, only Node.js v18 is allowed. Whereas, this package is also working with Node.js v20 for example.

When running npm install:

npm WARN EBADENGINE Unsupported engine {
npm WARN EBADENGINE   package: 'editorconfig-checker@5.1.0',
npm WARN EBADENGINE   required: { node: '^18.0.0' },
npm WARN EBADENGINE   current: { node: 'v20.3.0', npm: '9.7.1' }
npm WARN EBADENGINE }

Is it possible to merge this PR, and release it quickly as a patch version, 5.1.1, thanks! :smile:

theoludwig commented 1 year ago

cc @mstruebing

mstruebing commented 1 year ago

Anyone interesting in fixing this?

theoludwig commented 1 year ago

Anyone interesting in fixing this?

@mstruebing Sorry I didn't understand, what do you mean? :sweat_smile:

nsballmann commented 1 year ago

@mstruebing When do you plan on releasing this as 5.1.1 or similar?

mstruebing commented 1 year ago

I can do it today, sorry for the delay.

mstruebing commented 1 year ago

It's out there @nsballmann https://www.npmjs.com/package/editorconfig-checker/v/5.1.1

nsballmann commented 1 year ago

@mstruebing Awesome. Thank you very much. :100:

github-actions[bot] commented 4 months ago

:tada: This PR is included in version 1.5.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: