Until now, the file's coding system was set via an advice on insert-file-contents, which depends on being called from within the find-file-noselect advice.
While it mostly works, it doesn't account for all the cases (e.g. it fails to be used when doing write-region), is a bit cumbersome, and does not interact well with Emacs's other ways to specify a coding-system, such as auto-coding-alist.
This patch replaces it with an advice on find-auto-coding, so as to integrate better with the rest of Emacs's handling of files' coding systems. An immediate benefit is that we don't need to special case jar and zip files any more because auto-coding-alist does it for us already (and for many more file types like tar, exe, ...).
editorconfig.el (editorconfig-merge-coding-systems): Use merge-coding-systems only when merging is actually necessary. (editorconfig-set-coding-system-revert): Adjust accordingly. (editorconfig--filename-codingsystem-hash): Delete variable. (editorconfig--advice-insert-file-contents): Delete function. (editorconfig--advice-find-auto-coding): New function. (editorconfig--advice-find-file-noselect): Don't mess with coding systems any more.
(editorconfig--getting-coding-system): New var.
(editorconfig--get-coding-system): New function.
(editorconfig-mode): Advise find-auto-coding instead of insert-file-contents.
(editorconfig-version): Use package-get-version when available. (find-library-name, lm-version): Move their declaration to the place where we have a good reason to think they're defined. (editorconfig-exclude-regexps): Remove jar and zip patterns, not needed any more.
monnier
commented
1 month ago
Until now, the file's coding system was set via an advice on
insert-file-contents, which depends on being called from within thefind-file-noselectadvice. While it mostly works, it doesn't account for all the cases (e.g. it fails to be used when doingwrite-region), is a bit cumbersome, and does not interact well with Emacs's other ways to specify a coding-system, such asauto-coding-alist.This patch replaces it with an advice on
find-auto-coding, so as to integrate better with the rest of Emacs's handling of files' coding systems. An immediate benefit is that we don't need to special case jar and zip files any more becauseauto-coding-alistdoes it for us already (and for many more file types like tar, exe, ...).merge-coding-systemsonly when merging is actually necessary. (editorconfig-set-coding-system-revert): Adjust accordingly. (editorconfig--filename-codingsystem-hash): Delete variable. (editorconfig--advice-insert-file-contents): Delete function. (editorconfig--advice-find-auto-coding): New function. (editorconfig--advice-find-file-noselect): Don't mess with coding systems any more. (editorconfig--getting-coding-system): New var. (editorconfig--get-coding-system): New function. (editorconfig-mode): Advisefind-auto-codinginstead ofinsert-file-contents. (editorconfig-version): Usepackage-get-versionwhen available. (find-library-name, lm-version): Move their declaration to the place where we have a good reason to think they're defined. (editorconfig-exclude-regexps): Remove jar and zip patterns, not needed any more.