Assume gedit 3 is the default for install.sh

editorconfig / editorconfig-gedit

EditorConfig plugin for Gedit

http://editorconfig.org

Other

54 stars 13 forks source link

Assume gedit 3 is the default for install.sh #19

Closed jefferyto closed 5 years ago

jefferyto commented 6 years ago

This changes install.sh to:

assume gedit 3 is the default version and test for older versions
assume a normal user and test for root user
fix patching of editorconfig.plugin, since it already uses the python 3 loader

jefferyto commented 5 years ago

Umm... I don't see how the issues addressed in this PR are "fixed". The first two points (assume gedit 3 as default, assume normal user) can be argued as "nice to have" only, but the third point (patching editorconfig.plugin) is necessary.

gedit < 3.8 uses Python 2, gedit >= 3.8 uses Python 3. (I see the core library still supports Python 2.7 so I assume this plugin still supports gedit < 3.8.) As it stands, install.sh will not patch editorconfig.plugin correctly for gedit < 3.8 users.

xuhdev commented 5 years ago

It's actually a subtree merge and we happened to have a fix #19 in the commit message in our subtree. I'll reopen this now.

xuhdev commented 5 years ago

Thanks!