search

editorconfig / editorconfig-gedit

EditorConfig plugin for Gedit
http://editorconfig.org
Other
54 stars 13 forks source link

Include editorconfig core when installing #2

Closed jefferyto closed 6 years ago

jefferyto commented 11 years ago

The install script didn't include installing the core library, leaving the plugin broken; this addition installs the entire package.

Side note: my gedit seems to use my home directory as its working directory, so when shared.py appends abspath('../editorconfig-core-py/') to sys.path, it actually added '/home/editorconfig-core-py'. I didn't remove this as it seems to be harmless, but you may want to take a look at this as well.

xuhdev commented 11 years ago

@jefferyto Personally in my opinion it would be more convenient if the core could be automatically installed. But I think it might be better if there is an option for user to decide whether to do so, since some may already decide to use other versions of the core library, such as the latest development version.

treyhunner commented 11 years ago

Thanks for submitting this issue and pull request @jefferyto.

I do think the plugin should work automatically, but I would prefer that the library not be installed globally. The submodule we have now is meant to allow the plugin to use the library without installing it.

My favored solution: fix the (apparently broken) submodule.

jefferyto commented 11 years ago

As a user, I don't really care where the library is installed. Fixing the submodule import may be the best solution, but this was the fastest :-)

If it's preferable, I can add a command-line switch to opt out of installing the library.

mcepl commented 6 years ago

I think this could be replace by #17 , couldn't it?

jefferyto commented 6 years ago

Upon reflection (5 years worth :laughing:), using the library in place is better than installing it globally - closing.