editorconfig / editorconfig-notepad-plus-plus

EditorConfig plugin for Notepad++
http://editorconfig.org
GNU General Public License v2.0
191 stars 30 forks source link

No 64bit version for Notepad++ v7 #9

Closed piotr-cz closed 5 years ago

piotr-cz commented 7 years ago

Notepad++ v7 is available in both 32bit and 64bit editions.

EditorConfig plugin v0.3.1 doesn't work in the latter one.

ffes commented 7 years ago

And as Don writes on the release page of Notepad++ 7 only a few 64-bit plugins exist. https://notepad-plus-plus.org/news/notepad-7-released.html

I haven't even taken a look on how difficult it is to build 64-bit plugins and what problems to expect. I don't see myself running the 64-bit version any time soon because too many plugins are missing. So I will stick with the 32-bit for while.

Having said that, you are right. There has to be a 64-bit version of the plugin.

piotr-cz commented 7 years ago

I've updated Notepad++ to v7 using Chocolatey which automatically picked 64bit edition so without reading release notes.

I may switch to 32bit edition because at this moment even Plugin manager isn't compatible with 64bit.

xuhdev commented 7 years ago

I'll mark this issue on my TODO list. Thanks for the reporting!

ameer1234567890 commented 7 years ago

If more developers like developer of this plugin makes 64bit versions, the problem of "only a few 64-bit plugins exist" would be resolved soon.

viceice commented 7 years ago

Hi,

I've build a x64 version from master with pcre (8.38) and editorconfig-core-c (master). Please have a try.

If all is working, i will provied build information.

Regards Michael

NppEditorConfig.zip

image

wangqr commented 7 years ago

I have just tried to build the x64 version. The only difference is to select the Win64 generator in CMake, and everything works fine. So I think it is a trivial task to add it to the plugin manager list.

To add the x64 version to the plugin manager list, we need to:

xuhdev commented 7 years ago

@wangqr Awesome! Do you wanna look into #16 ?

wangqr commented 7 years ago

Currently this project is building using CMake, and the README.md is quite clear about how to build the plugin. Are the scripts in #16 used for automated build/release? I haven't used PowerShell scripts before, maybe I'll take a look.

viceice commented 7 years ago

Please have a look. I've prepared the scripts from #16 for automated build. I can provide them in any other language when required. ;)

We use the 64bit build on production without problems.

Regards Michael

tannergooding commented 7 years ago

@ViceIce, I've been using the 64-bit version you linked above for the whole month now and haven't seen any issues.

piotr-cz commented 6 years ago

@ViceIce Thanks! 👍 Looks like it's working fine

Predelnik commented 6 years ago

Is there any progress on this issue? Could at least x64 version be added to releases even if build scripts are not perfect?

chcg commented 6 years ago

See https://ci.appveyor.com/project/xuhdev/editorconfig-notepad-plus-plus/build/1.0.3/job/n4lic6kswnt840wb/artifacts. @xuhdev How about creation of a new release?

chcg commented 6 years ago

@ffes @xuhdev Do you have a timeframe to release a x64 version? With the appveyor config that is available by just a few steps.

AnyOldName3 commented 6 years ago

This is still not showing up in the plugin manager for me, but it looks like there've been no actual issues for a year.

chcg commented 5 years ago

@xuhdev Why is this issue closed? I see a working appveyor build, but no release yet. Appveyor artifacts are just available for 6 month. PluginManager and N++ PluginAdmin need a zip package (with the dll in the root dir) to add a new release version to the plugin lists.

ffes commented 5 years ago

Version 0.4.0 had been released. This release should solve this issue, therefore I am closing this issue.

Note that the plugin is not yet available in the builtin Plugin Admin of Notepad++. I opened notepad-plus-plus/nppPluginList#63 to update that. When the plugin will be available in Notepad++ itself is beyond us, but you can download and manually install it from the releases page.