Closed k-takata closed 1 year ago
Would you be willing to add some test cases of files with different encodings?
Do we need to add some test cases with a .editorconfig
file with UTF-8 BOM? Then, should https://github.com/editorconfig/editorconfig-plugin-tests be updated?
Would you be willing to add some test cases of files with different encodings?
Do we need to add some test cases with a
.editorconfig
file with UTF-8 BOM? Then, should https://github.com/editorconfig/editorconfig-plugin-tests be updated?
@k-takata Good question! I don't think we need to update the main plugin tests, since this problem is specific to this plugin. If you or @h3xx can send me some test cases, I'll figure out where to put them.
How about creating a copy of https://github.com/editorconfig/editorconfig-plugin-tests/tree/master/test_files with just adding a UTF-8 BOM to test_files/.editorconfig
?
+1 for this PR. Tested these changes against the issue in my PR #194, and it in fact fixes the issue I described.
This PR seems more comprehensive than my change so I closed #194.
This will also fix https://github.com/editorconfig/editorconfig-vim/issues/196
Merged --- let me know if you experience any issues!
Changing 'encoding' has many side effects and that should be avoided. Strip BOM manually.
Fix #144 Fix #145 Fix #147