search

editorconfig / editorconfig-vim

EditorConfig plugin for Vim
http://editorconfig.org
Other
3.14k stars 139 forks source link

Respect modifiable flag when trimming whitespace #84

Closed op closed 7 years ago

op commented 7 years ago

Refs #83.

xuhdev commented 7 years ago

Thanks!

b0o commented 7 years ago

Hey! Thanks for this, I've been having the same issue for a while now and it's been bugging me.

I checked out your branch and it did make the error go away, but now I'm getting two new splits popping up:

screen shot 2017-04-18 at 10 01 03 am

Here's what it looks like with the old master before your commit (26781c577da740786a4d1723ddaddfef79701e32):

screen shot 2017-04-18 at 10 10 00 am

I'm not sure if this is a problem with vim-go or editorconfig-vim or if this is the intended behavior?

xuhdev commented 7 years ago

@b0o This looks like some go lint program shows the error. It's unlikely to be related to editorconfig-vim. You can check whether it is caused by vim-go or syntax_checker or something similar.

b0o commented 7 years ago

@xuhdev Yeah, sorry. The panes are both from vim-go, one of them is GoLint and the other is GoMetaLinter.

I think what was happening was that prior to @op's fix, the error was causing only GoLint to run and not GoMetaLinter, so when it was fixed I was confused because I was so used to the old behavior. 😝