search

editorconfig / editorconfig.github.com

Configuration file format for defining coding styles in shared projects
http://editorconfig.org
Other
265 stars 42 forks source link

Include a link to EditorConfig-Action #117

Open xuhdev opened 5 years ago

xuhdev commented 5 years ago

I would add on the website a link to EditorConfig-Action (excellent work!), which uses eclint. @jedmao opinions?

xuhdev commented 5 years ago

cc @zbeekman

jednano commented 5 years ago

I don't see why not; though, ECLint is one of those projects that seemed like a good idea at the time, but now I regret creating it. Only because it's not AST-aware, which means it can't really do a reliable job at fixing or even checking indentation.

I recommend Prettier, which supports multiple file formats as well as EditorConfig. On top of that, language specific tools should be doing the job.

zbeekman commented 5 years ago

While I agree that tools which are AST aware can provide much better functionality, for some languages, like Fortran (modern and antiquated) there are currently no such tools and eclint & others play a valuable role. If Prettier supported Fortran I would probably use that instead, however, for a lot of languages that just isn't an option.

I would fully support a link to EditorConfig-Action on the EditorConfig website, if you would like to put one there.

xuhdev commented 5 years ago

@zbeekman Do you have a logo? If you don't have one, I'm thinking about what can be the best image as a placeholder...

zbeekman commented 5 years ago

https://github.com/zbeekman/EditorConfig-Action/blob/master/assets/GH-social.xcf is the GIMP file I used for the social preview. Feel free to hack out the topline github logo & text or otherwise modify it. Otherwise, the combination of OctoCat Double Blink, Square Heart and EditorConfig Logo is the closest thing I have to an official logo. These could stand to have an anti-aliasing pass, but I have other things I need to do at the moment.

Something like:

![ocdb](https://github.com/zbeekman/EditorConfig-Action/raw/master/assets/ocdb.gif) ![sqhr](https://github.com/zbeekman/EditorConfig-Action/raw/master/assets/sqhr.png) ![ecl](https://github.com/zbeekman/EditorConfig-Action/raw/master/assets/ecl.png)
xuhdev commented 5 years ago

@zbeekman Sorry for the delay. Would you mind sending a PR for this? I'm not sure though whether GitHub allows us to do so...