search

editorconfig / editorconfig.github.com

Configuration file format for defining coding styles in shared projects
http://editorconfig.org
Other
265 stars 42 forks source link

Update Carbon CSS #121

Closed sayzlim closed 5 years ago

sayzlim commented 5 years ago

Matches the ad design with the sidebar styles. See the screenshot here:

jednano commented 5 years ago

Thanks!

jednano commented 5 years ago

I just noticed the ads don't show up on a mobile device. Any ideas there?

jednano commented 5 years ago

I suppose this is the kind of site that is way less likely to be hit on a mobile device, as people will be writing code.

sayzlim commented 5 years ago

Agree. We track the impressions on every API request, but most people will visit the site on the desktop. Let’s consider the impressions from mobile browser as additional revenue for the project.

Thanks for merging the PR @jedmao!