search

editorconfig / editorconfig.github.com

Configuration file format for defining coding styles in shared projects
http://editorconfig.org
Other
267 stars 42 forks source link

Add VSCodium #141

Closed kmk3 closed 3 years ago

kmk3 commented 3 years ago

"binary releases of VS Code without MS branding/telemetry/licensing"

Since Visual Studio Code is present, might as well add the Free/Libre version of it.

Logo taken from: https://github.com/VSCodium/vscodium/blob/cb5e22e005a1e3373f5e0ee9bb79d182587db2df/src/resources/linux/code.png

Pittan commented 3 years ago

@kmk3 Thank you for your contribution!
As you already seen on editorconfig.org, we are using hand-written style logo. Using the original logo maybe okay, but creating a hand-written style logo will fit in with rest of the logos.

Could you add the image on your PR? If you not in hurry, I can create the image and put it on this PR's comment.

@xuhdev what do you think about this?

xuhdev commented 3 years ago

Yeah I agree with @Pittan . @kmk3 Could you share the logo image? We will redraw the logo to fit to the style of the rest of the page (thanks to @Pittan and Kat for the conversion)

Pittan commented 3 years ago

@xuhdev I think the image is attached to this PR.

kmk3 commented 3 years ago

@Pittan commented yesterday:

@kmk3

Thank you for your contribution!

No problem.

As you already seen on editorconfig.com, we are using hand-written style logo.

Funny thing; I had noticed that in the past, but this time I was just looking at the vim and vscode logos on the site and thought that they looked pretty similar to the originals (or that they were the originals), so I just went and grabbed the official vscodium logo.

Using the original logo maybe okay, but creating a hand-written style logo will fit in with rest of the logos.

Indeed, and I like the hand-written style.

Could you add the image on your PR? If you not in hurry, I can create the image and put it on this PR's comment.

I have no drawing skills and there is no hurry, so feel free to do that :p

By the way, what are the tools used to create these logos?

Pittan commented 3 years ago

@kmk3

I have no drawing skills and there is no hurry, so feel free to do that :p

By the way, what are the tools used to create these logos?

Thanks! I'll create a logo image and attach to this PR's comment later today. I'm using Photoshop + iPad Sidecar to redraw logos. (Maybe too much for this kind of task :))

Pittan commented 3 years ago

@kmk3 Sorry to be late 🙇 Here's the hand-written version of VSCodium logo. vscodium

Pittan commented 3 years ago

Wait... may be we should add a border around the logo (It will blend to the background but we should avoid it) Just a sec...

Pittan commented 3 years ago

https://github.com/editorconfig/editorconfig.github.com/pull/141#issuecomment-922500893 Image updated!

xuhdev commented 3 years ago

Awesome! @Pittan Would you like me to add the logo in a separate PR or would you prefer opening a PR by yourself?

Pittan commented 3 years ago

@xuhdev Thank you! I was thinking that @kmk3 will swap this image to the image included in this PR.

kmk3 commented 3 years ago

@Pittan commented on Sep 19:

@kmk3 Sorry to be late bow

It's alright.

Here's the hand-written version of VSCodium logo. vscodium

Nice, it looks very close to the original.

@Pittan commented on Sep 20:

I was thinking that @kmk3 will swap this image to the image included in this PR.

My thought as well; I've swapped and force-pushed. I put the credits on the commit message.

xuhdev commented 3 years ago

Thanks @kmk3 . Could you add the following to your git message? This should automatically credit @Pittan (replace AT and DOT with @ and .)

Co-authored-by: pittan <amon.keishima AT pittankopta DOT net>
kmk3 commented 3 years ago

@xuhdev commented on Sep 20:

Thanks @kmk3 . Could you add the following to your git message? This should automatically credit @Pittan (replace AT and DOT with @ and .)

Co-authored-by: pittan <amon.keishima AT pittankopta DOT net>

Sure, but are you certain that the above is correct? On @Pittan's latest non-merge commit (commit 3e54962 ("Add GitLab (#133)")), the author is listed as:

Amon Keishima <pittan AT pittankopta DOT net>
Pittan commented 3 years ago

@kmk3 pittan at pittankopta dot net is an alias to amon.keishima at ... so it doesn't matter which one I / you choose :)

kmk3 commented 3 years ago

@Pittan commented on Oct 2:

@kmk3 pittan at pittankopta dot net is an alias to amon.keishima at ... so it doesn't matter which one I / you choose :)

Ah, good to know.

@kmk3 commented on Sep 21:

@xuhdev commented on Sep 20:

Thanks @kmk3 . Could you add the following to your git message? This should automatically credit @Pittan (replace AT and DOT with @ and .)

Co-authored-by: pittan <amon.keishima AT pittankopta DOT net>

Sure, but are you certain that the above is correct? On @Pittan's latest non-merge commit (commit 3e54962 ("Add GitLab (#133)")), the author is listed as:

Amon Keishima <pittan AT pittankopta DOT net>

Now I noticed that I was checking the commits on this PR branch rather than on master (sorry about that). @Pittan's latest commit on master is 223cc0d ("Add Pluma"), so your original suggestion appears to be the more fitting one indeed.

I went with that one and force-pushed.