editorconfig / editorconfig.github.com

Configuration file format for defining coding styles in shared projects
http://editorconfig.org
Other
265 stars 42 forks source link

Revert "default.html: remove site.baseurl from anchors (#145)" #147

Closed kmk3 closed 3 years ago

kmk3 commented 3 years ago

This reverts commit a4cd6975708a0c9543c51ac89084ce472678b20b.

That commit breaks the changed nav links on /blog, as the anchors are specific to / (i.e.: the home page).


Link to the original PR: #145.

kmk3 commented 3 years ago

Sorry about that; I forgot that there are more pages and that the nav is global at the same time.

xuhdev commented 3 years ago

Nice catch again! Thanks!

kmk3 commented 3 years ago

I recently noticed this: commit 67a887a ("Add a Jekyll-based blog (#57)").

$ git show --pretty='' 67a887aa -- _layouts/default.html | grep '#'
-      <li><a href="#overview">What is EditorConfig?</a></li>
-      <li><a href="#example-file">Example File</a></li>
-      <li><a href="#file-location">File Location</a></li>
-      <li><a href="#file-format-details">File Format Details</a></li>
-      <li><a href="#download">Download a Plugin</a></li>
-      <li><a href="#contributing">Contributing</a></li>
+      <li><a href="{{ site.baseurl }}/#overview">What is EditorConfig?</a></li>
+      <li><a href="{{ site.baseurl }}/#example-file">Example File</a></li>
+      <li><a href="{{ site.baseurl }}/#file-location">File Location</a></li>
+      <li><a href="{{ site.baseurl }}/#file-format-details">File Format Details</a></li>
+      <li><a href="{{ site.baseurl }}/#download">Download a Plugin</a></li>
+      <li><a href="{{ site.baseurl }}/#contributing">Contributing</a></li>

Wish I had seen that earlier hehe