search

editorconfig / editorconfig.github.com

Configuration file format for defining coding styles in shared projects
http://editorconfig.org
Other
267 stars 42 forks source link

Added .DS_Store to .gitignore #54

Closed mitchdenny closed 8 years ago

mitchdenny commented 8 years ago

Useful for when you open up the images directory in the finder window on your Mac. This was the change that I previously backed out from the previous pull request.

xuhdev commented 8 years ago

Thanks!

jednano commented 8 years ago

I still think this belongs in your global .gitignore, as it doesn't concern, say, Windows users.

xuhdev commented 8 years ago

@jedmao It does not matter---windows users should not add .DS_Store any way as it conflicts with some OS X features.

jednano commented 8 years ago

Yeah, my point is that projects shouldn't have to add .DS_Store to their .gitignore files, but instead expect users to add it to their own global .gitignore file, but that might be too optimistic to expect everyone to do that.

Similarly, if this is the way things are going, why not add Thumbs.db as well?

xuhdev commented 8 years ago

@jedmao Sure, we don't have to, but it doesn't hurt to add :) You are free to add thumbs.db.

jednano commented 8 years ago

It's already in my global .gitignore, so no need, but I'm just making a point.

mitchdenny commented 8 years ago

The way I see it (and the reason I added it) was that the .gitignore file is just a way of the project saying - we don't want these files added. So I guess the question is, do you want the .DS_Store files being added? You can't always rely on folks having their global .gitignore which meets the requirements of your project. To me, it makes sense for the project to say what files they don't want in their repository (even if it overlaps with a users global settings).