Closed mitchdenny closed 8 years ago
Thanks!
I still think this belongs in your global .gitignore, as it doesn't concern, say, Windows users.
@jedmao It does not matter---windows users should not add .DS_Store
any way as it conflicts with some OS X features.
Yeah, my point is that projects shouldn't have to add .DS_Store
to their .gitignore
files, but instead expect users to add it to their own global .gitignore
file, but that might be too optimistic to expect everyone to do that.
Similarly, if this is the way things are going, why not add Thumbs.db
as well?
@jedmao Sure, we don't have to, but it doesn't hurt to add :) You are free to add thumbs.db
.
It's already in my global .gitignore
, so no need, but I'm just making a point.
The way I see it (and the reason I added it) was that the .gitignore file is just a way of the project saying - we don't want these files added. So I guess the question is, do you want the .DS_Store
files being added? You can't always rely on folks having their global .gitignore
which meets the requirements of your project. To me, it makes sense for the project to say what files they don't want in their repository (even if it overlaps with a users global settings).
Useful for when you open up the images directory in the finder window on your Mac. This was the change that I previously backed out from the previous pull request.