search

editorconfig / editorconfig.github.com

Configuration file format for defining coding styles in shared projects
http://editorconfig.org
Other
266 stars 42 forks source link

Change Visual Studio to "no plugin necessary" #68

Closed treyhunner closed 7 years ago

treyhunner commented 7 years ago

Per @Mpdreamz's tweet

Maybe we should wait until after VS2017 is officially released to merge this.

Also where should this link point to?

ffes commented 7 years ago

I would hold this back until it is officially released.

The feature is announced for the RC in https://www.visualstudio.com/en-us/news/releasenotes/vs2017-relnotes (search for EditorConfig) no anchor to point to.

poke commented 7 years ago

Bump. This can be merged now, VS 2017 has been out for a while now.

jednano commented 7 years ago

Also, insert_final_newline and trim_trailing_whitespace properties are not supported.

I think people might still want to download the extension, but the extension should probably be updated to remove the baked-in features of Visual Studio and just handle these two properties ☝️ that aren't supported.

treyhunner commented 7 years ago

@jedmao should we link to https://github.com/editorconfig/editorconfig-visualstudio#readme instead of the announcement page and explain the situation there?

jednano commented 7 years ago

@treyhunner that sounds like a solid plan!

treyhunner commented 7 years ago

@jedmao updated the link and merged