search

editorconfig / editorconfig.github.com

Configuration file format for defining coding styles in shared projects
http://editorconfig.org
Other
267 stars 42 forks source link

Redesign website #7

Closed treyhunner closed 11 years ago

treyhunner commented 11 years ago

I'd like some opinions on this redesign. This is just a series of minor CSS tweaks, so it's all easy to adjust further.

I'm not sure how I feel about the small-caps or the uncentered layout (due to the now short and readable main content area). I haven't figured out how to position the left sidebar as fixed to the top of the page but relatively centered with the rest of the content.

CC: @xuhdev @sindresorhus @jedhunsaker @bellkev @johan

Opinions welcome from anyone.

selection_054

xuhdev commented 11 years ago

For me it looks better. It's also interesting that you flipped the logo. It looks a little empty on the right margin. Maybe we can fill something there?

johan commented 11 years ago

Gut feeling: the left-looking logo looks more sophisticated. If you flip it, though, be sure to flip the favicon to match.

The old christmas-tree-mode hilighted/colorized file example also was a nice touch I miss a little in the new version.

treyhunner commented 11 years ago

At first I lined up the current left-facing logo to the right side of the side bar to line it up with the grid more, but it left an empty space on the left that felt odd. I'm not sure how I feel about the flipped logo either.

Maybe we should move the sidebar up to the top and stick the logo next to the EditorConfig header? Or fill that sidebar header space with something else.

The example file should be colorized on the live site... it's just not colorizing for me locally for some reason. I assume I don't have pygments installed/setup or something.

bellkev commented 11 years ago

Hey Trey,

I checked out your site changes, and they indeed show up as colorized for me. Also, I think I figured out a good way to center things while keeping the sidebar vertically fixed. I added it to the pull request.

On Sat, Aug 17, 2013 at 3:39 PM, Trey Hunner notifications@github.comwrote:

At first I lined up the current left-facing logo to the right side of the side bar to line it up with the grid more, but it left an empty space on the left that felt odd. I'm not sure how I feel about the flipped logo either.

Maybe we should move the sidebar up to the top and stick the logo next to the EditorConfig header? Or fill that sidebar header space with something else.

The example file should be colorized on the live site... it's just not colorizing for me locally for some reason. I assume I don't have pygments installed/setup or something.

— Reply to this email directly or view it on GitHubhttps://github.com/editorconfig/editorconfig.github.com/pull/7#issuecomment-22821020 .

treyhunner commented 11 years ago

That centering looks much better in my opinion. Thanks @bellkev. I changed the styling of the navigation select/hover states some and I flipped the logo back.

Here's what it looks like for me now: selection_055

I'm also planning to convert the Download a Plugin section to a table of icons drawn by @ineptcat for each supported editor. The icon styles will be based on the ones in this presentation slide with more for each of the JetBrains ones. I may make a separate pull request for that.

Thanks for all the feedback so far! More welcome.

johan commented 11 years ago

— / Johan Sundström

On Sun, Aug 18, 2013 at 12:59 AM, Trey Hunner notifications@github.com wrote:

That centering looks much better in my opinion. Thanks @bellkev. I changed the styling of the navigation select/hover states some and I flipped the logo back. Here's what it looks like for me now: selection_055 I'm also planning to convert the Download a Plugin section to a table of icons drawn by @ineptcat for each supported editor. The icon styles will be based on the ones in this presentation slide with more for each of the JetBrains ones. I may make a separate pull request for that.

Thanks for all the feedback so far! More welcome.

Reply to this email directly or view it on GitHub: https://github.com/editorconfig/editorconfig.github.com/pull/7#issuecomment-22826365

johan commented 11 years ago

Odd; trying again:

That looks great!

Any reason not to just grab the osx app icon for each app instead, and probably get as good and instant visual recognition as we can? (Artist help is nice, but probably best used to create assets that don't already exist and are related to the project itself, IMO.)

treyhunner commented 11 years ago

@johan I agree with you in general, but I do like the hand-drawn look of these. I haven't found other assets that we need yet besides the logo.

I just added them to the pull request. Here's how they look:

selection_056

I may be merging this soon.

bellkev commented 11 years ago

Liking all the JetBrains logos! :) I need to figure out what AppCode is, and whether the plugin works for it... :P

Sent from my iPhone

On Aug 18, 2013, at 12:09 PM, Trey Hunner notifications@github.com wrote:

@johan I agree with you in general, but I do like the hand-drawn look of these. I haven't found other assets that we need yet besides the logo.

I just added them to the pull request. Here's how they look:

I may be merging this soon.

\ Reply to this email directly or view it on GitHub.

bellkev commented 11 years ago

The site's looking great on mobile now. Good work, Trey!

On Sun, Aug 18, 2013 at 12:38 PM, Kevin Bell kevin.a.bell@gmail.com wrote:

Liking all the JetBrains logos! :) I need to figure out what AppCode is, and whether the plugin works for it... :P

Sent from my iPhone

On Aug 18, 2013, at 12:09 PM, Trey Hunner notifications@github.com wrote:

@johan https://github.com/johan I agree with you in general, but I do like the hand-drawn look of these. I haven't found other assets that we need yet besides the logo.

I just added them to the pull request. Here's how they look:

[image: selection_056]https://f.cloud.github.com/assets/285352/983030/6837dd84-0839-11e3-83e0-f3bced4141f3.png

I may be merging this soon.

— Reply to this email directly or view it on GitHubhttps://github.com/editorconfig/editorconfig.github.com/pull/7#issuecomment-22836865 .

xuhdev commented 11 years ago

Thanks @treyhunner ! The website now looks great!

treyhunner commented 11 years ago

About one third of our traffic is from mobile, so the website needs to stay responsive. There's a big traffic spike right now from retweets about the design revamp and about half of that traffic is mobile.

Thanks all for the feedback and help.

Pull requests welcome for suggested future improvements. There's always more to be improved.