search

editorconfig / editorconfig.github.com

Configuration file format for defining coding styles in shared projects
http://editorconfig.org
Other
267 stars 42 forks source link

Contain the highlighted area when sample code is selected #9

Closed bellkev closed 11 years ago

bellkev commented 11 years ago

It seems likely that a common thing to do on editorconfig.org would be to copy-and-paste some text from the sample (then edit it to suit your needs).

I thought it would be nice if the highlighting when text is selected didn't spill over the sides of the pre-formatted block.

Here's an example of what it looks like now: screen shot 2013-08-27 at 6 53 24 pm

And with the proposed change: screen shot 2013-08-27 at 6 53 50 pm

I tried to set the boundaries to emulate what it would look like if the selection were made in a text editor (i.e. just barely containing the characters on left side).

xuhdev commented 11 years ago

I agree with this change. This is much nicer.

jednano commented 11 years ago

:+1:

treyhunner commented 11 years ago

Awesome. Thanks!

xuhdev commented 11 years ago

@treyhunner Besides the sample code, I think maybe other parts of the text should also be improved in this way? Some people may wanna cite this web page.

treyhunner commented 11 years ago

@xuhdev I agree