search

edk2-porting / edk2-msm

Broken edk2 port for Qualcomm platforms xD
https://renegade-project.tech/
BSD 2-Clause "Simplified" License
2.32k stars 439 forks source link

Update PlatformMemoryMapLib (sm8250) #191

Closed musabcel closed 1 year ago

lujianhua commented 1 year ago

This commit seems to revert https://github.com/edk2-porting/edk2-msm/commit/1ddab83791c12b39c89af2c9ddec9c97bd0a9da6, isn't a normal PR, please descript it correct. And this commit will cause xiaomi-elish fails to boot linux, I don't known why you want to revert it.

MollySophia commented 1 year ago

This commit seems to revert 1ddab83, isn't a normal PR, please descript it correct. And this commit whill cause xiaomi-elish fails to boot linux, I don't known why you want to revert it.

Actually the previous commit breaks the Windows booting on oneplus 8 pro, causing crashdump. I think the project structure needs some changes. I'll make memorymaps more device-specific soon

lujianhua commented 1 year ago

This commit seems to revert 1ddab83, isn't a normal PR, please descript it correct. And this commit whill cause xiaomi-elish fails to boot linux, I don't known why you want to revert it.

Actually the previous commit breaks the Windows booting on oneplus 8 pro, causing crashdump. I think the project structure needs some changes. I'll make memorymaps more device-specific soon

All the changes I done is tested under linux but isn't tested under windows, sorry.

MollySophia commented 1 year ago

This commit seems to revert 1ddab83, isn't a normal PR, please descript it correct. And this commit whill cause xiaomi-elish fails to boot linux, I don't known why you want to revert it.

Actually the previous commit breaks the Windows booting on oneplus 8 pro, causing crashdump. I think the project structure needs some changes. I'll make memorymaps more device-specific soon

All the changes I done is tested under linux but isn't tested under windows, sorry.

I didn't think enough before clicking on the merge button so :)