search

edk2-porting / edk2-msm

Broken edk2 port for Qualcomm platforms xD
https://renegade-project.tech/
BSD 2-Clause "Simplified" License
2.31k stars 438 forks source link

Update it #386

Closed ETCHDEV closed 1 month ago

ETCHDEV commented 5 months ago

Description

[Description of the changes you are submitting]

Checklist

gus33000 commented 5 months ago

Edk2 main branch is known to introduce breaking changes often breaking the build process. As a result if you drop the last commit here you may one day make builds fail due to an update on their end. I think it would be better to set the last known good commit sha1 instead of removing it all together. Even if you can rely on git submodule functionality it at least documents nicely the commit intended to work

gus33000 commented 1 month ago

@ETCHDEV whats the point of this PR? I have not gotten an answer on this and it looks like you made a change 2 days ago. Should we close this? You do not seem open to discussing https://github.com/edk2-porting/edk2-msm/pull/386#issuecomment-2074646627 or make changes

ETCHDEV commented 1 month ago

Sorry for late reply, but ya I am closing the commit has this commit does nothing

n00b69 commented 1 month ago

@ETCHDEV Poor lisa

ETCHDEV commented 1 month ago

Btw you can tell in grp that lisa is sold now. So no, not returning to woa on lisa