search

edk2-porting / edk2-rk3588

EDK2 UEFI firmware for Rockchip RK3588 platforms
490 stars 97 forks source link

Revert "Fydetab Duo: fixes for SDcard" #159

Closed runaway97 closed 2 months ago

runaway97 commented 2 months ago

With current change, SD card no longer appears in UEFI Boot Manager. Looking at commit history, the problem is already described and workaround: https://github.com/edk2-porting/edk2-rk3588/commit/c02b333c22b4fff4569c6dcaa2b84696edae4ce3 (same as current change: bad) https://github.com/edk2-porting/edk2-rk3588/commit/416b2fa11b031aa894bfccbc57e9be75388fdea1 (actual solution)

The Fydetab Duo motherboard has SDMMC_DET inverted, which is against Rockchip design. This is a hardware mistake that prevents the RK3588 MaskROM to boot from SD card when tray is fully closed. No software fix is possible because MaskROM is read-only. Therefore, in order to boot UEFI firmware and OS from SD card, the tray has to be left ajar and UEFI firmware must not invert the state once again.

This allows UEFI firmware to detect the SD card no matter if tray is fully in or partially.

@fydepanda @mariobalanica @MollySophia @yunshansimon

MollySophia commented 2 months ago

Someone said in discord that the previous PR was tested on a Fydetab Duo without an issue. I don't have the device myself, so I cannot test either of these. I guess it's reverting is the best thing to do now. Sorry for my being not cautious enough previously

fydepanda commented 2 months ago

I just want to add that i think i forgot to update the spl blob since I was just given a git diff for the SDcard fix, heres a conversation between me and @yunshansimon (we are both working at Fyde) image image Ill wait to hear from him tomorrow sorry for the inconveniences caused by me @MollySophia