edkinsgael / airhead-research

Automatically exported from code.google.com/p/airhead-research
0 stars 0 forks source link

Review new DependencyVectorSpace code and additional interfaces #54

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
Please review the dv package
Also, check out the various changes to DependencyExtractor

M    src/edu/ucla/sspace/lsa/LatentSemanticAnalysis.java
M    src/edu/ucla/sspace/matrix/LogEntropyTransform.java

- Fixed weird character that was messing up the javadoc

M    src/edu/ucla/sspace/text/IteratorFactory.java

- Change Misc to ReflectionUtil

M    src/edu/ucla/sspace/matrix/CorrelationTransform.java

- Updated File based method to use MatrixIO to load the file into a Matrix.
  This change implements the two methods, provided at that the matrix can fit
  into memory.

M    src/edu/ucla/sspace/matrix/MatrixIO.java

- Added missing private constructor

M    src/edu/ucla/sspace/mains/StructuredVectorSpaceMain.java
M    src/edu/ucla/sspace/mains/DependencyRandomIndexingMain.java

- Updated to use new DependencyExtractorManager and hook to
  setupDependencyExtractor()

M    src/edu/ucla/sspace/mains/DependencyGenericMain.java

- Change method to set up the DependencyExtractorManager based on the parameter
  configuration, rather than to pass the Extractor to the instances themselves.

AM   src/edu/ucla/sspace/mains/DependencyVectorSpaceMain.java

- Added a main for running the DV code

A    src/edu/ucla/sspace/dv

- Added package for the DV code

AM   src/edu/ucla/sspace/dv/MinimumTemplateAcceptor.java
AM   src/edu/ucla/sspace/dv/MaximumTemplateAcceptor.java
AM   src/edu/ucla/sspace/dv/MediumTemplateAcceptor.java

- Added DependencyPathAcceptor that has Pado and Lapata's templates hard-coded

AM   src/edu/ucla/sspace/dv/WordBasedBasisMapping.java

- Added a basis mapping that ignores the grammatical relation of a path

AM   src/edu/ucla/sspace/dv/DependencyPathBasisMapping.java

- Added an BasisMapping subinterface for handling DependencyPaths

AM   src/edu/ucla/sspace/dv/RelationBasedBasisMapping.java

- Added a BasisMapping that is specific to word+relation for a path

AM   src/edu/ucla/sspace/dv/BasisMapping.java

- Added a templated interface that maps an object to an integer dimension.

AM   src/edu/ucla/sspace/dv/DependencyVectorSpace.java

- Added an implementation of the Dependency Vector Space model described by Pado
  and Lapata

M    src/edu/ucla/sspace/svs/StructuredVectorSpace.java
M    src/edu/ucla/sspace/dri/DependencyRandomIndexing.java

- Updated constructor to remove the DependencyExtractor parameter.  Instead the
  DE is obtained from the DependencyExtractorManager.

M    src/edu/ucla/sspace/util/TrieMap.java

- Removed some dead code

- Added more informative comments

- Renamed method for clarity

A  + src/edu/ucla/sspace/util/ReflectionUtil.java
D    src/edu/ucla/sspace/util/Misc.java

- Renamed class to ReflectionUtil for more intuitive description of what the
  class does

AM   src/edu/ucla/sspace/dependency/CoNLLDependencyExtractor.java

- Renamed the original DependencyExtractor to CoNLL* to make room for the DE
  interface.

AM   src/edu/ucla/sspace/dependency/DependencyExtractorManager.java

- Added class in the spirit of LogManager that acts as a library-wide repository
  for DependencyExtractor instances.

M    src/edu/ucla/sspace/dependency/SimpleDependencyPath.java

- Updated javadoc

AM   src/edu/ucla/sspace/dependency/FilteredDependencyIterator.java

- Added a DependencyPathIterator instance that filters based on an
  DepencyPathAcceptor

AM   src/edu/ucla/sspace/dependency/WaCKyDependencyExtractor.java

- Added a DependencyExtractor instance that handles the WaCKy special CoNLL
  formating

M    src/edu/ucla/sspace/dependency/DependencyExtractor.java

- Reworked to be an interface in order to support future DE implementations

AM   src/edu/ucla/sspace/dependency/DependencyPathAcceptor.java

- Added an acceptor based on paths

M    src/edu/ucla/sspace/dependency/DependencyIterator.java

- Added a special case to stop early to improve efficiency

M    src/edu/ucla/sspace/dependency/DependencyPath.java

- Added javadoc comment

Original issue reported on code.google.com by David.Ju...@gmail.com on 17 Jun 2010 at 3:49

GoogleCodeExporter commented 8 years ago
Set review issue status to: Done

Original comment by FozzietheBeat@gmail.com on 26 Jun 2010 at 7:40