search

edkolev / evil-goggles

Display visual hint on evil edit operations
222 stars 13 forks source link

[WIP] add support for lispville #26

Open JJPandari opened 4 years ago

JJPandari commented 4 years ago

This is still a work in progress.

I love lispyville, and would like to add support for it in evil-goggles.

The current code change should be working as I tested, but two commands are not added because they don't satisfy evil-goggle's convention of taking BEG END as arguments: 

  (lispyville->                    :face evil-goggles-shift-face                 :switch evil-goggles-enable-shift                 :advice evil-goggles--generic-async-advice)
  (lispyville-<                    :face evil-goggles-shift-face                 :switch evil-goggles-enable-shift                 :advice evil-goggles--generic-async-advice)

@noctuid Do you use evil-goggles? what do you think?

OH and those :switchs obviously need more refining before this PR can be merged.

noctuid commented 4 years ago

I'm not using it at the moment, but let me know if there's anything I can do in lispyville to make integration easier.

JJPandari commented 4 years ago

two commands are not added because they don't satisfy evil-goggle's convention of taking BEG END as arguments:

Just found there's no way to make lispyville-< and lispyville-> work without changing lispy's code, because functions like lispy--barf-backward actually barf by moving the ), while to me the user, it's the barfed sexp being moved and should be goggled.

For the :switchs I'm not sure if we should reuse existing ones or make new ones, waiting for response from the maintainers...

wbolster commented 4 years ago

i considered adding support for lispyville as well, but it turns out someone beat me to it! even better! :+1:

@edkolev is there anything we can do to help moving this forward?