search

edkolev / tmuxline.vim

Simple tmux statusline generator with support for powerline symbols and statusline / airline / lightline integration
MIT License
1.61k stars 90 forks source link

Use consistent color in tmuxline with airline #38

Open paulhybryant opened 9 years ago

paulhybryant commented 9 years ago

Airline use a bright color for the tab that is selected, I think tmuxline should be consistent with that?

Sent a PR for this issue.

Thanks!

edkolev commented 9 years ago

Thank you for the pull request.

I would prefer not to modify all the airline themes (airline, airline_insert, airline_visual). Also, if someone doesn't use airline's tabline feature (which is by default off), the tmux colors will not be consistent with the tabline (because tabline is not visible).

Still, I do think this is a useful addition. Could you implement it as a separate theme? For example autoload/tmuxline/themes/airline_tabline.vim. Before return-ing here https://github.com/edkolev/tmuxline.vim/blob/master/autoload/tmuxline/themes/airline_visual.vim#L12 the colors should be modified.

Then users will have to set this in vimrc let g:tmuxline_preset = 'airline_tabline'

paulhybryant commented 9 years ago

Sure. What is the difference between theme and preset? If I implement this as a theme, shouldn't the user specify let g:tmuxline_theme = 'airline_tabline' instead of setting g:tmuxline_preset?

Thanks,

edkolev commented 9 years ago

Sorry, I copy-pasted incorrectly. User should set g:tmuxline_theme

Let me know if you run into any issues.

justmytwospence commented 9 years ago

+1 either changing the theme or creating a new one

paulhybryant commented 9 years ago

I have updated the PR and include this as a new theme.

Thanks.

paulhybryant commented 8 years ago

Please take a look at the PR. Thanks,