search

edlink / edlink-node-sdk

An Edlink API wrapper for NodeJS.
https://npmjs.com/package/@edlink/typescript
5 stars 1 forks source link

Axios vs Fetch #28

Open benaduggan opened 4 months ago

benaduggan commented 4 months ago

Curious about the choice to use Axios in this repo rather than falling back to just fetch. We were looking to move something to the edge runtime in Vercel, but axios depends on some apis that don't exist in the edge runtime unfortunately

https://github.com/edlink/edlink-node-sdk/blob/ce2098dd5655b22b05a0d5b7cd2100354e4b11bc/src/index.ts#L1

jaronpate commented 4 months ago

Hey @benaduggan. Happy to hear you're using the SDK! Looks like you are correct about this. There is no reason other than we use axios in our other projects internally.

Unfortunately I'm not able to guarantee I can undertake swapping out axios at the moment. Personally though I don't think we are relying on anything in axios that isn't easily reproducible.

Let me speak to my team lead and get back to you. Any timeline for you on this btw?

benaduggan commented 4 months ago

No worries! There's no concrete reason for us to move to the edge runtime other than a likely sub-second latency increase for some of our users. Otherwise it's just part of my ongoing quest to convince the world fetch is all we need these days 😇

Let him know as a bonus you can advertise it as a zero-dependency sdk afterwards! 😉

jaronpate commented 4 months ago

Ha you read my mind. Would be dope for it to be zero-dependency. It would sound cool anyway lol. Heard on that though!

jaronpate commented 4 months ago

Hey Ben. I will add this to our long term roadmap but this isn't something I can tackle in the next few months. I did take a wack at in for 30-ish mins and sadly couldn't get it working easily in the jest tests (surprise surprise, jest messing with things). We have other priorities for back to school right now that we have to prioritize but I will keep this in mind. If it becomes more of a priority reach out here or to your CSM!