edmcouncil / fibo

The Financial Industry Business Ontology (FIBO) defines the sets of things that are of interest in financial business applications and the ways that those things can relate to one another. In this way, FIBO can give meaning to any data (e.g., spreadsheets, relational databases, XML documents) that describe the business of finance.
https://spec.edmcouncil.org/fibo/
MIT License
329 stars 68 forks source link

Typo in label of JurisdictionOfPoland fixed #1741

Closed mereolog closed 2 years ago

mereolog commented 2 years ago

Signed-off-by: mereolog pawel.garbacz@makolab.com

Description

This fix the typo in the label of JurisdictionOfPoland

Fixes: #1715

Checklist:

mereolog commented 2 years ago

RDF serialization went berserk for this commit.

$ git commit -sm "typo fixed"
rdf-toolkit: sesame-serializer: This is the pre-commit hook
rdf-toolkit: sesame-serializer: java_home = .../jdk-16.0.1.jdk/Contents/Home/
rdf-toolkit: sesame-serializer: whichJava = .../jdk-16.0.1.jdk/Contents/Home//bin/java
rdf-toolkit: sesame-serializer: Found rdf-toolkit: .../fibo/.git/hooks/rdf-toolkit.jar
rdf-toolkit: sesame-serializer: Launching the sesame-serializer with --source BE/GovernmentEntities/EuropeanJurisdiction/EasternEuropeGovernmentEntitiesAndJurisdictions.rdf
+ .../jdk-16.0.1.jdk/Contents/Home//bin/java -Xmx1g -Dorg.clapper.avsl.config=/tmp/sesame-serializer-log -cp .../fibo/.git/hooks/rdf-toolkit.jar org.edmcouncil.rdf_toolkit.RdfFormatter --source BE/GovernmentEntities/EuropeanJurisdiction/EasternEuropeGovernmentEntitiesAndJurisdictions.rdf --target BE/GovernmentEntities/EuropeanJurisdiction/EasternEuropeGovernmentEntitiesAndJurisdictions.rdfX --target-format rdf-xml --use-dtd-subset --inline-blank-nodes --infer-base-iri
+ rc=0
+ set +x
rdf-toolkit: sesame-serializer: Re-adding potentially re-serialized file to git staging area: BE/GovernmentEntities/EuropeanJurisdiction/EasternEuropeGovernmentEntitiesAndJurisdictions.rdf
[fibo-1715 fc790374] typo fixed
 1 file changed, 338 insertions(+), 338 deletions(-)
trojczak commented 2 years ago

@mereolog When I compare these files manually, I can see that there is only one change: Screenshot from 2022-03-02 14-04-58

This seems like some kind of problem with Git internal comparator. Or maybe there is some problem with the way how ending of lines are used.

ElisaKendall commented 2 years ago

@mereolog I think it could be the line endings - we have attempted to be consistent in what we've done for FIBO ontologies, but a recent update to Windows made CRLF default for some of my files, and our preference has been Unix style LF only. You might attempt to change that back to LF and see if that fixes it.

mereolog commented 2 years ago

@mereolog I think it could be the line endings - we have attempted to be consistent in what we've done for FIBO ontologies, but a recent update to Windows made CRLF default for some of my files, and our preference has been Unix style LF only. You might attempt to change that back to LF and see if that fixes it.

Currently CLRF line terminators are replaced by LF line terminators by rdf-toolkit by default. This file is one among 7 files which have CLRF line terminators. These will be replaced by LF line terminators when they are updated. So we will have to suffer this six more time. Here is the list of these files:

./BE/AllBE-NorthAmerica.rdf
./BE/GovernmentEntities/EuropeanJurisdiction/NorthernEuropeGovernmentEntitiesAndJurisdictions.rdf
./BE/GovernmentEntities/EuropeanJurisdiction/SouthernEuropeGovernmentEntitiesAndJurisdictions.rdf
./BE/GovernmentEntities/NorthAmericanJurisdiction/CaribbeanGovernmentEntitiesAndJurisdictions.rdf
./SEC/Funds/MetadataSECFunds.rdf
./SEC/Securities/SecuritiesIdentificationIndividuals.rdf