search

edmcouncil / fibo

The Financial Industry Business Ontology (FIBO) defines the sets of things that are of interest in financial business applications and the ways that those things can relate to one another. In this way, FIBO can give meaning to any data (e.g., spreadsheets, relational databases, XML documents) that describe the business of finance.
https://spec.edmcouncil.org/fibo/
MIT License
305 stars 66 forks source link

Deprecated resources in use #2021

Closed mereolog closed 1 day ago

mereolog commented 6 days ago

There are three deprecated resources still in use:

  1. https://spec.edmcouncil.org/fibo/ontology/FND/Relations/Relations/hasIdentity
  2. https://spec.edmcouncil.org/fibo/ontology/SEC/Securities/SecuritiesIdentificationIndividuals/ReutersInstrumentCodeScheme
  3. https://spec.edmcouncil.org/fibo/ontology/SEC/Securities/ParametricSchedules/ParametricSchedule

They were found by https://jenkins.edmcouncil.org/job/fibo/job/hygine_test_update/3

ElisaKendall commented 3 days ago

@merelog The use of fibo-sec-sec-idind;ReutersInstrumentCodeScheme is strictly with respect to having an owl:sameAs statement in the deprecated resource, which should be allowed for named individuals

ElisaKendall commented 3 days ago

@merelog The use of fibo-sec-sec-sch;ParametricSchedule is strictly with respect to having an editorial note that we have not removed, mainly due to some detail that we might want for further revisions downstream. I can remove the note, which would address the hygiene issue, but if you add something to ignore annotations on deprecated resources, then it would not show up as being still in use.

mereolog commented 3 days ago

This looks fine, but note that I fixed the check for the deprecated resources, and now it finds quite a lot of them — see: https://jenkins.edmcouncil.org/job/fibo/view/change-requests/job/PR-2026/3/.

I looked at a couple of them, and they seem to be genuine issues, e.g., https://spec.edmcouncil.org/fibo/ontology/FND/Accounting/ISO4217-CurrencyCodes/HRK, in the sense that they are deprecated resources that relate to other resources.