DER-113 - Need to connect properties of a swap to the legs that may "inherit" those properties

[ElisaKendall]

Description

Cleaned up the definitions of and added notes on swap and swap leg, per the issue; also eliminated a long-time deprecated element

Fixes: #2059 / DER-113

Checklist:

• [x] I'm familiar with the FIBO developer quide. My contribution meets all the requirements described there.
• [x] My contribution follows the principles of best practices for FIBO.
• [x] My changes have been reconciled with latest master and no merge conflicts remain.
• [x] This PR is related to exactly one issue. The issue is referenced by using a GitHub keyword such as "fixes", "closes", or "resolves".
• [x] Hygiene tests have been applied by a PR with "(WIP)" in title.
• [x] The issue has been tested locally using a reasoner (for ontology changes).