edmcouncil / idmp

This repository stores the OWL ontology built on the basis of the ISO standards for identification of medicinal products.
https://spec.edmcouncil.org/idmp/
MIT License
29 stars 10 forks source link

Possibly identical individuals whose difference would make IDMPO inconsistent #560

Open mereolog opened 5 months ago

mereolog commented 5 months ago

The table below shows all individuals (from ec8ee5e) such that:

  1. they are not declared as identical (owl:sameAs) or different (owl:differentFrom)
  2. if they were declared different, this would make the IDMP ontology inconsistent because of the functional properties in which these individuals are involved in.

image possible_identity_gaps 202403220934.xlsx

I think that at least some of them look as different individuals.

(The triples which would make the ontology inconsistent are shown here: possible_identity_gaps full_search 202403220934.xlsx)

ElisaKendall commented 5 months ago

@mereolog - I would have to dig in to the details to see what's going on here. If @tw-osthus has time to look into this, that would be helpful. I won't be able to spend the time to debug until after 4/1.

tw-osthus commented 5 months ago

https://precision.fda.gov/uniisearch/srs/unii/136P0076YA is same substance as https://gsrs.ncats.nih.gov/api/v1/substances/136P0076YA

and the like are correct.

https://precision.fda.gov/uniisearch/srs/unii/${UNII_ID} == https://gsrs.ncats.nih.gov/api/v1/substances/${UNII_ID}

GSRS is using the UNII identifier as part of their IRI. The official UNII URI is the first one.

https://spec.pistoiaalliance.org/idmp/ontology/EXT/Examples/TerlipressinExample/TerlipressinAcetate should be replaced with the GSRS URI

all the others are most likely wrong and must be fixed

mereolog commented 4 months ago

As for:

all the others are most likely wrong and must be fixed

What do you mean that they are wrong?

mereolog commented 4 months ago

@tw-osthus , @ElisaKendall would it make sense to fully execute the comment below, i.e., to add all implicit sameAs triples?

https://precision.fda.gov/uniisearch/srs/unii/136P0076YA is same substance as https://gsrs.ncats.nih.gov/api/v1/substances/136P0076YA

and the like are correct.

https://precision.fda.gov/uniisearch/srs/unii/${UNII_ID} == https://gsrs.ncats.nih.gov/api/v1/substances/${UNII_ID}