search

edmcouncil / idmp

This repository stores the OWL ontology built on the basis of the ISO standards for identification of medicinal products.
https://spec.edmcouncil.org/idmp/
MIT License
29 stars 10 forks source link

Obsolete restriction on idmp-sub:Amount #598

Closed mereolog closed 3 months ago

mereolog commented 4 months ago

https://spec.pistoiaalliance.org/idmp/ontology/ISO/ISO11238-Substances/Amount has an obsolete restriction:

https://github.com/edmcouncil/idmp/blob/57ef7480b0077090bec5df07eb1d589f07a1500d/ISO/ISO11238-Substances.rdf#L276-L280

which can be inherited from its other restriction:

https://github.com/edmcouncil/idmp/blob/57ef7480b0077090bec5df07eb1d589f07a1500d/ISO/ISO11238-Substances.rdf#L269-L273

This was revealed by https://jenkins.edmcouncil.org/view/idmp/job/idmp/job/additional_hygiene_test_for_obsolete_restrictions/4/.

ElisaKendall commented 3 months ago

@merelog - We've agreed to change the cardinality for the hasQuantityValueRange restriction to 2, rather than one, in the case where there might be both a range and reference range.

ElisaKendall commented 3 months ago

The resolution to this issue was merged via pull request #603