search

edmcouncil / idmp

This repository stores the OWL ontology built on the basis of the ISO standards for identification of medicinal products.
https://spec.edmcouncil.org/idmp/
MIT License
32 stars 10 forks source link

GitHub-577 - Potentially vicious "circular" restrictions #600

Closed ElisaKendall closed 5 months ago

ElisaKendall commented 6 months ago

Description:

  1. Removed unnecessary (and circular) restrictions from the Commons quantities and units ontology (the other two are definitional and min 0)
  2. Reviewed the "circular" definition in MVF, which is optional (min 0 and definitional), and needs to remain in the ontology.
  3. Reviewed the two restrictions on ConceptDescriptor - these are also optional and definitional, and should remain in the ontology.
  4. Issues with the current model for basic and pharmaceutical dose form will be addressed in a separate resolution, as they require additional work to clean up and augment the model to better reflect the details provided in ISO 11239. See https://dil-edmcouncil.atlassian.net/browse/IDMP-739.
  5. Reviewed the restrictions on MedicinalProductAuthorization and JurisdictionalMedicinalProductAuthorization, and these need to remain in the ontology as they are optional and definitional.
ElisaKendall commented 6 months ago

@mereolog The two restrictions on ConceptDescriptor are also definitional and min 0, so they need to remain.