search

edmund-huber / ergonomadic

DISCONTINUED, see orogono
MIT License
132 stars 10 forks source link

WebSocket layer to be able to connect "web" client #12

Closed stumpyfr closed 9 years ago

stumpyfr commented 9 years ago

Currently working with a mini irc js implem, the flow:

works and the ping/pong timeout keep the communication open.

edmund-huber commented 9 years ago

Nice. I will test this later tonight. Is your frontend also opensource? Can you give / show me your set up so I can test it the way you tested it?

stumpyfr commented 9 years ago

Sadly not...no yet. I will open the irc js part, not all the client. To test, I used on my side: https://github.com/gorilla/websocket/blob/master/examples/chat/home.html

Need to send all the commands and after the USER, you will get the reply with the MOTD and all the "welcome" payload.

Not the easiest way I need to admit but working :)

edmund-huber commented 9 years ago

OK, looking good, here's a test trace (ergonomadic output):

2015/05/04 22:53:05 127.0.0.1:60165 → PASS test
2015/05/04 22:53:15 127.0.0.1:60165 → NICK edmundinho
2015/05/04 22:53:23 127.0.0.1:60165 → USER edmundinho edmundinho localhost :Edmund Huber
2015/05/04 22:53:23 127.0.0.1:60165 ← :localhost 001 edmundinho :Welcome to the Internet Relay Network edmundinho!edmundinho@localhost
2015/05/04 22:53:23 127.0.0.1:60165 ← :localhost 002 edmundinho :Your host is localhost, running version ergonomadic-1.4.4
2015/05/04 22:53:23 127.0.0.1:60165 ← :localhost 004 edmundinho localhost ergonomadic-1.4.4 aio beIikntPpTl
2015/05/04 22:53:23 127.0.0.1:60165 ← :localhost 422 edmundinho :MOTD File is missing
2015/05/04 22:53:30 127.0.0.1:60165 → JOIN #test
2015/05/04 22:53:30 127.0.0.1:60165 ← :edmundinho!edmundinho@localhost JOIN #test
2015/05/04 22:53:30 127.0.0.1:60165 ← :localhost 353 edmundinho = #test :@edmundinho
2015/05/04 22:53:30 127.0.0.1:60165 ← :localhost 366 edmundinho #test :End of NAMES list
2015/05/04 22:54:30 127.0.0.1:60165 ← PING :localhost

I have to do the PONGs myself right?

Then please just address or comment on the things I pointed out and we're good to go. :)

stumpyfr commented 9 years ago

Some inline comment, I will make some fix later, I am currently in travel, difficult to find time on my computer.

edmund-huber commented 9 years ago

@stumpyfr ping, how long do you think fixups will take? Do you mind if I take a whack if you are busy? :)

stumpyfr commented 9 years ago

Hi,

back from my travel but a little bit on rush, if you have time dont hesitate to move forward. I will not be able to do that before next weekend...in the best case.

edmund-huber commented 9 years ago

Continued in https://github.com/edmund-huber/ergonomadic/pull/14.